Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI for every pull request (no matter which branch) #165

Merged
merged 1 commit into from
May 6, 2022

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented May 6, 2022

Doesn't it make more sense to run our CI for every branch? Because otherwise the CI will not run when we split a PR into multiple branches like:

main
   big_feature_1
      sub_feature_for_feature_1
      sub_feature_for_feature_2

I think it would be helpful to also run the CI when you merge sub_feature_for_feature_1 into big_feature. Of course, there could be the case sub_feature_for_feature_1 has some unfinished tests or wrong lints, because it's part of big_feature, but I think in these special cases we could skip the CI (or using skip: true in the tests).

@github-actions
Copy link

github-actions bot commented May 6, 2022

Visit the preview URL for this PR (updated for commit 01bdf35):

https://sharezone-test--pr165-nilsreichardt-patch-ki153qy0.web.app

(expires Fri, 13 May 2022 07:54:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nilsreichardt nilsreichardt merged commit 17e8962 into main May 6, 2022
@nilsreichardt nilsreichardt deleted the nilsreichardt-patch-1 branch May 6, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants