Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join option when long pressing course while being a member #1679

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Fix join option when long pressing course while being a member #1679

merged 1 commit into from
Jun 30, 2024

Conversation

ImGxrke
Copy link
Contributor

@ImGxrke ImGxrke commented Jun 29, 2024

Fixes #825

@github-actions github-actions bot added feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. labels Jun 29, 2024
@Jonas-Sander Jonas-Sander added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jun 30, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jun 30, 2024
Copy link

Visit the preview URL for this PR (updated for commit 721ee3f):

https://sharezone-test--pr1679-fix-long-press-join-kim1d9tq.web.app

(expires Wed, 03 Jul 2024 13:19:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job 🎉

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Jun 30, 2024
Merged via the queue into SharezoneApp:main with commit ebcdec1 Jun 30, 2024
50 of 51 checks passed
@ImGxrke ImGxrke deleted the fix-long-press-join-option branch June 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes.
Projects
None yet
2 participants