Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sz pub get work somewhat on windows. #17

Merged
merged 0 commits into from
Jul 22, 2021
Merged

Make sz pub get work somewhat on windows. #17

merged 0 commits into from
Jul 22, 2021

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Jul 12, 2021 •
edited
Loading

TODO: Test that it still works on mac

@Jonas-Sander
Copy link
Collaborator Author

Still works on macOS 👍

nilsreichardt
nilsreichardt approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/sz_repo_cli/lib/src/common/common.dart Outdated Show resolved Hide resolved
@nilsreichardt
Copy link
Member

Don't forget to remove [WIP] before merging

@Jonas-Sander Jonas-Sander changed the title [WIP] Make sz pub get work somewhat on windows. Make sz pub get work somewhat on windows. Jul 22, 2021
@Jonas-Sander Jonas-Sander merged this pull request into main Jul 22, 2021
@Jonas-Sander Jonas-Sander deleted the windows-sz-cli branch July 22, 2021 16:01
nilsreichardt pushed a commit that referenced this pull request Sep 24, 2023
@Jonas-Sander
(Small change to trigger CD pipeline) (#17)
ac065a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt