Use for test job a macOS machine to be able to run golden tests
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 2ad453a): https://sharezone-test--pr220-use-macos-machine-fo-pjx6pjz7.web.app (expires Wed, 18 May 2022 22:59:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| - run: echo $(realpath ./bin) >> $GITHUB_PATH | ||
| - run: echo $(pwd)/bin >> $GITHUB_PATH |
There was a problem hiding this comment.
Out of curiosity: Why did you change this? Did realpath lead to problems?
Jonas-Sander
approved these changes
May 12, 2022
nilsreichardt
added a commit
that referenced
this pull request
May 17, 2022
## Description This PR contains a proposal to display an alpha version banner. Users which are using an alpha version should be aware that is an alpha version. Therefore, a small banner at the top right-hand corner indicates this. This banner also helps us when somebody sends a screenshot of an alpha version. We can instantly see that is an alpha version. When this proposal got accepted, we can add the environment variable to the `deploy_web_app` workflow. ## Demo <img width="1135" alt="image" src="https://user-images.githubusercontent.com/24459435/167873877-2a0f512b-14c9-4ee9-a0f8-5662c5c26b52.png"> ## Related Tickets Related to #27 The PR #220 should be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138 & #216 are adding golden tests. Golden tests can only run on one platform. We decided to pick macOS as the platform because primary using macOS. Therefore, should our CI use macOS machines. Otherwise, the Golden Tests are skipped.