Use --web-renderer canvaskit flag instead of --dart-define=FLUTTER_WEB_USE_SKIA=true to deploy the web app via sz deploy web-app
#233
Conversation
…_WEB_USE_SKIA=true`
| '--dart-define=FLUTTER_WEB_USE_SKIA=true' | ||
| '--web-renderer', | ||
| 'canvaskit', |
There was a problem hiding this comment.
Wouldn't auto be better for mobile devices? Or is there sth that makes it unsuitable for us?
There was a problem hiding this comment.
I think having only canvaskit as renderer is better for us now, because we had some issues with the html renderer and the performance was terrible. Additionally, using auto would require to maintain two renderers which would result into more work for us and looking at the analytics it's not worth for that few web users.
There was a problem hiding this comment.
We can use the canvas kit renderer for now, but back when we had the performance problems that was quite a while ago. We should test that again (might very well still be true of course).
Also what would be the overhead for "maintaining" it? I think it should more or less just work. Sure there is a slightly higher chance for bugs but if it works for us when we just scroll through once then I think the chance of new bugs occuring out of nowhere should be slim.
There was a problem hiding this comment.
I agree that our goal should be using someday auto but with maintaining I mean we need to (manually) test the current features but also every upcoming feature.
|
Visit the preview URL for this PR (updated for commit 32deff8): https://sharezone-test--pr233-use-web-renderer-fla-sze7gioo.web.app (expires Tue, 24 May 2022 15:28:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Regarding the official Flutter docs, you can set the renderer via the
--web-rendererflag: https://docs.flutter.dev/development/platform-integration/web/renderers#command-line-options