Fix Android builds for CI machines & drop for support macOS video player #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsreichardt
added
the
feature: file-sharing
|
Visit the preview URL for this PR (updated for commit bdf8d2e): https://sharezone-test--pr241-fix-android-build-fo-cpkhgxbu.web.app (expires Wed, 25 May 2022 13:09:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
nilsreichardt
commented
May 18, 2022
Comment on lines
+39
to
+50
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_1_8 | ||
| targetCompatibility JavaVersion.VERSION_1_8 | ||
| } | ||
|
|
||
| kotlinOptions { | ||
| jvmTarget = '1.8' | ||
| } | ||
|
|
||
| sourceSets { | ||
| main.java.srcDirs += 'src/main/kotlin' | ||
| } |
There was a problem hiding this comment.
If you're wondering where I get this from: I copied this from the Flutter counter app when you create a new Flutter app with flutter create app (I used Flutter 2.10.5).
Jonas-Sander
approved these changes
May 18, 2022
nilsreichardt
changed the title
nilsreichardt
changed the title
nilsreichardt
added a commit
that referenced
this pull request
May 18, 2022
## Description This PR adds an Alpha track for Android, like we already have for web with https://alpha.web.sharezone.net. On every commit on the `main`, we build a new Android version. Because Firebase Distribution doesn't care about versioning, we don't need a complicated system for increasing the version number. As release note we are using the last commit message. Users can join the Alpha track via this link: https://appdistribution.firebase.dev/i/9c4942a1c01a5496. Just follow the introductions by Google. But I think we should also add our own docs later (How to join the alpha program, how to leave, etc.). Would be good to do #166 first. We should first merge the following PR before merging this PR: * #241 Closes #215
nilsreichardt
added a commit
that referenced
this pull request
May 19, 2022
nilsreichardt
added a commit
that referenced
this pull request
May 19, 2022
## Description In #241 I updated the `video_player` package and should have also run an iOS build to update the iOS files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in #237 described were we unable to build for Android. This PR fixes this problem. There were several problems:
com.android.tools.build:gradleto4.1.0Execution failed for task ':fast_rsa:stripDebugDebugSymbols'.from Android builds are failing in CI environments #237Could not determine artifacts for com.google.android.exoplayer:exoplayer-hls:2.12.1: Skipped due to earlier error.video_playerpackage.Builds with check the fix:
This unblocks:
Fixes #237