Use correct iOS bundle ID for dev environment #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit d618d14): https://sharezone-test--pr249-fix-bundle-id-dev-gihbymj5.web.app (expires Thu, 26 May 2022 11:39:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Jonas-Sander
approved these changes
May 19, 2022
nilsreichardt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems so that we just for all the time the wrong bundle ID in the dev environment. With this PR, we are now using the
de.codingbrain.sharezone.app.devbundle ID for the dev environment.I didn’t test everything manually but signing in and loading data Firestore works (needed to add the bundle ID
de.codingbrain.sharezone.app.devto the API restrictions)Related Tickets
Fixes #248