Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use English download badges in README.md and align the same height #259

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

nilsreichardt
Copy link
Member

Before

image

After

image

Using the official badges by Apple: https://developer.apple.com/app-store/marketing/guidelines/

Related Tickets

Closes #141

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Visit the preview URL for this PR (updated for commit 6562140):

https://sharezone-test--pr259-update-download-badg-o6h0frgn.web.app

(expires Wed, 15 Jun 2022 18:33:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Jonas-Sander
Copy link
Collaborator

Aligning the height makes it look weird on mobile though:

Before
Screenshot_20220607-231348.png

After
Screenshot_20220607-231413.png

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above - can this be fixed?

@nilsreichardt
Copy link
Member Author

After fixing:

image
(mobile)

image
(desktop)

The fix is to use width instead of height

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@nilsreichardt nilsreichardt merged commit d9ba796 into main Jun 9, 2022
@nilsreichardt nilsreichardt deleted the update-download-badges branch June 9, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppStore buttons in README.md are in German
2 participants