Set permissions for workflows to follow a good security practice. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit fd425c8): https://sharezone-test--pr300-set-github-action-de-19rcpvpg.web.app (expires Wed, 05 Oct 2022 22:30:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Jonas-Sander
requested changes
Sep 28, 2022
.github/workflows/main.yml
Outdated
| @@ -154,6 +160,9 @@ jobs: | |||
| # 4. Adjust website restrictions for Firebase Key "Sharezone Web Key". | |||
| web-preview: | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| pull-requests: write # for FirebaseExtended/action-hosting-deploy to comment on PRs | |||
| checks: write # for FirebaseExtended/action-hosting-deploy | |||
There was a problem hiding this comment.
Couldn't find what the checks permissions is exactly for. Can you add it to the comment next to it?
There was a problem hiding this comment.
The thing is that I also don't know why it's needed but without it's not posting the comment. It also needs to be write. read is not working.
There was a problem hiding this comment.
Added the comment
for FirebaseExtended/action-hosting-deploy to comment on PRs (without write permissions for checks the action doesn't post a comment to the PR)
Co-authored-by: Jonas Sander <[email protected]>
Co-authored-by: Jonas Sander <[email protected]>
Co-authored-by: Jonas Sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having workflows without setting the permission for the workflow is considered a bad security practice and it is causing alerts from our scanning tools.