Remove Time.copyWithAddedMinutes and add Time.isNextDayWith
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsreichardt
commented
Sep 29, 2022
| @@ -169,12 +169,17 @@ class Periods { | |||
| number: 1, startTime: Time(hour: 7), endTime: Time(hour: 8)); | |||
| } else { | |||
| final lastPeriod = getPeriods()?.last; | |||
| final durationOfLastPeriod = | |||
| final minutesOfLastPeriod = | |||
There was a problem hiding this comment.
Just renaming the variable because durationOfLastPeriod suggests that the type is Duration.
|
Visit the preview URL for this PR (updated for commit 10a46cd): https://sharezone-test--pr306-remove-copy-with-add-p13e7ev7.web.app (expires Thu, 06 Oct 2022 07:38:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
⬇️ Generated builds by Codemagic for commit 10a46cd ⬇️ Note: Only Sharezone team members are able to install the iOS app.
|
Jonas-Sander
approved these changes
Sep 29, 2022
nilsreichardt
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick refactoring of remove
Time.copyWithAddedMinutesand addingTime.isNextDayWith.Time.copyWithAddedMinuteshas been used in the timetable settings to configure the period times.Manually testing:
RPReplay_Final1664443554.MP4
Closes #303