Refactor holiday code into separate holidays package #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
|
Visit the preview URL for this PR (updated for commit bd0224f): https://sharezone-test--pr324-holidays-package-muwj3kmy.web.app (expires Sat, 14 Jan 2023 00:02:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
|
⬇️ Generated builds by Codemagic for commit bd0224f ⬇️ Note: Only Sharezone team members are able to install the iOS app.
|
Jonas-Sander
added a commit
that referenced
this pull request
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved most of the holiday code to
lib/holidays.I left holidays_bloc inside of the
appcode since it interacts with theUserGatewayand is more specific to the dashboard page widget.I didn't change any logic.
I ran the app manually on the mac to check if it still works.
Requires #329.