-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Licence check ignore generated dart files #325
Conversation
Visit the preview URL for this PR (updated for commit 0e5b5ef): https://sharezone-test--pr325-licence-check-ignore-z4ah4bqz.web.app (expires Mon, 16 Jan 2023 17:24:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
FYI: The app preview check is failing because the GitHub API changed (I think) and I need to fix this in the package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would be great to add this command to the Sharezone CLI in the future because when add later more file types to ignore, we can just this command.
For FlutterFire I have added a Melos command (melos run add-license-header
): https://github.com/firebase/flutterfire/blob/08a4be6c0e86a3288bb6fcafd301f1519b7915ba/melos.yaml#L266
|
Do you have time to do this? Else all test runs for all the PRs will fail in the future, won't they? |
@nilsreichardt Should I merge this anyways or wait until the action is fixed? Don't really like to have |
When you don't need the changes in this month then you keep open the PR because I might fix this in the month. However, I'm okay with merging it now |
⬇️ Generated builds by Codemagic for commit 0e5b5ef ⬇️ Note: Only Sharezone team members are able to install the iOS app.
|
…generated-dart-files
No description provided.