Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licence check ignore generated dart files #325

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 28, 2022

Visit the preview URL for this PR (updated for commit 0e5b5ef):

https://sharezone-test--pr325-licence-check-ignore-z4ah4bqz.web.app

(expires Mon, 16 Jan 2023 17:24:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt
Copy link
Member

FYI: The app preview check is failing because the GitHub API changed (I think) and I need to fix this in the package

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be great to add this command to the Sharezone CLI in the future because when add later more file types to ignore, we can just this command.

For FlutterFire I have added a Melos command (melos run add-license-header): https://github.com/firebase/flutterfire/blob/08a4be6c0e86a3288bb6fcafd301f1519b7915ba/melos.yaml#L266

@Jonas-Sander
Copy link
Collaborator Author

LGTM

Would be great to add this command to the Sharezone CLI in the future because when add later more file types to ignore, we can just this command.

For FlutterFire I have added a Melos command (melos run add-license-header): https://github.com/firebase/flutterfire/blob/08a4be6c0e86a3288bb6fcafd301f1519b7915ba/melos.yaml#L266

#326

@Jonas-Sander
Copy link
Collaborator Author

FYI: The app preview check is failing because the GitHub API changed (I think) and I need to fix this in the package

Do you have time to do this? Else all test runs for all the PRs will fail in the future, won't they?

@Jonas-Sander
Copy link
Collaborator Author

FYI: The app preview check is failing because the GitHub API changed (I think) and I need to fix this in the package

@nilsreichardt Should I merge this anyways or wait until the action is fixed? Don't really like to have main failing as well.

@nilsreichardt
Copy link
Member

@nilsreichardt Should I merge this anyways or wait until the action is fixed? Don't really like to have main failing as well.

When you don't need the changes in this month then you keep open the PR because I might fix this in the month. However, I'm okay with merging it now

@nilsreichardt
Copy link
Member

nilsreichardt commented Jan 6, 2023

⬇️ Generated builds by Codemagic for commit 0e5b5ef ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS Android
image
Download link
image
Download link

@Jonas-Sander Jonas-Sander enabled auto-merge (squash) January 9, 2023 17:21
@Jonas-Sander Jonas-Sander merged commit e4fa7ea into main Jan 9, 2023
@Jonas-Sander Jonas-Sander deleted the licence-check-ignore-generated-dart-files branch January 9, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants