Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sharezone_lints for url_launcher_extended #416

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

nilsreichardt
Copy link
Member

I resolved the following warnings in this PR:

Nils-MBP-13-M1-3:url_launcher_extended nils$ flutter analyze
Analyzing url_launcher_extended...                                      

   info • The local variable '_canLaunch' starts with an underscore • lib/src/url_launcher_extended.dart:70:11 •
          no_leading_underscores_for_local_identifiers
   info • The local variable '_canLaunch' starts with an underscore • lib/src/url_launcher_extended.dart:119:11 •
          no_leading_underscores_for_local_identifiers
   info • The parameter name 'o' doesn't match the name 'other' in the overridden method • lib/src/url_launcher_extended.dart:136:27 •
          avoid_renaming_method_parameters
   info • The parameter name 'o' doesn't match the name 'other' in the overridden method • lib/src/url_launcher_extended.dart:160:27 •
          avoid_renaming_method_parameters
   info • Can't use a relative path to import a library in 'lib' • test/mock_url_launcher_extended_test.dart:12:8 • avoid_relative_lib_imports

5 issues found. (ran in 0.9s)

Part of #37

@github-actions github-actions bot added dependencies Changing, updating, adding or removing one or more dependencies. testing labels Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Visit the preview URL for this PR (updated for commit ac53f3d):

https://sharezone-test--pr416-use-sharezone-lints-wc74mfo5.web.app

(expires Mon, 13 Mar 2023 21:37:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt enabled auto-merge (squash) March 6, 2023 21:34
@nilsreichardt nilsreichardt merged commit 5f5b16b into main Mar 6, 2023
@nilsreichardt nilsreichardt deleted the use-sharezone-lints-for-url-launcher-extended branch March 6, 2023 22:02
@nilsreichardt nilsreichardt added the refactoring Restructuring and cleaning up existing code without changing its existing behaviour. label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing, updating, adding or removing one or more dependencies. refactoring Restructuring and cleaning up existing code without changing its existing behaviour. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants