-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sharezone_lints
to notifications
package
#423
Conversation
Visit the preview URL for this PR (updated for commit f5977b5): https://sharezone-test--pr423-add-sharezone-lints-0sjvocg0.web.app (expires Tue, 14 Mar 2023 21:48:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
}, | ||
executeActionRequest: (request) { | ||
print(request.stringToPrint); | ||
log(request.stringToPrint); | ||
}, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the thing is this is the code example for the documentation of the PushNotificationActionHandler
.
So I guess the example in the doc also needs to be updated, altough I think it would be more confusing to use log instead of print in the example.
So maybe just add ignore_for_file: avoid_print
to the top of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense. I added it in 1f6b5c7
This PR fixes the following warnings:
Part of #37