Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate abgabe_http_api to null safety #426

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Migrate abgabe_http_api to null safety #426

merged 4 commits into from
Apr 5, 2023

Conversation

nilsreichardt
Copy link
Member

Closes #212

@github-actions github-actions bot added the dependencies Changing, updating, adding or removing one or more dependencies. label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 479085a):

https://sharezone-test--pr426-migrate-abgabe-http-7gqfvcsw.web.app

(expires Wed, 12 Apr 2023 17:27:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

Jonas-Sander
Jonas-Sander approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test that it still works? (Can't test via web preview since its still broken) If it still works then it LGTM.
This library should probably be re-generated in the future by the correct tool, but if this works I would go with this for now.

@nilsreichardt nilsreichardt added the refactoring Restructuring and cleaning up existing code without changing its existing behaviour. label Mar 9, 2023
@nilsreichardt
Copy link
Member Author

nilsreichardt commented Mar 10, 2023 •
edited
Loading

Status: I wait with the merge because #440 is not merged right now. When #440 I can easily test the changes

@github-actions github-actions bot added the feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. label Apr 5, 2023
@nilsreichardt
Copy link
Member Author

image

Is working :)

@nilsreichardt nilsreichardt added this pull request to the merge queue Apr 5, 2023
Merged via the queue into main with commit 5c34d9b Apr 5, 2023
@nilsreichardt nilsreichardt deleted the migrate-abgabe-http-api-to-null-safety branch April 5, 2023 21:52
@nilsreichardt nilsreichardt mentioned this pull request Apr 6, 2023
Merged
nilsreichardt added a commit that referenced this pull request Apr 7, 2023
@nilsreichardt
Run sz pub get (#579)
4b43f08 
I think this is a missing change from #426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. refactoring Restructuring and cleaning up existing code without changing its existing behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate the abgabe_http_api package to null safety
2 participants
@nilsreichardt @Jonas-Sander