Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharezone_lints to sharezone_common #432

Merged
merged 4 commits into from
Mar 8, 2023

Conversation

nilsreichardt
Copy link
Member

Fixes as well:

Analyzing sharezone_common...                                           

   info • Don't invoke 'print' in production code • lib/src/api_errors/api_errors.dart:220:9 • avoid_print
   info • Statements in an if should be enclosed in a block • lib/src/api_errors/api_errors.dart:240:5 •
          curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/api_errors/api_errors.dart:242:5 •
          curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:79:11 • curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:81:11 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:85:11 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:87:11 • curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:89:11 • curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:91:11 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:104:43 •
          curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:105:7 • curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:110:7 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:150:7 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:156:7 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:158:7 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:165:7 • curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:223:9 • curly_braces_in_flow_control_structures
   info • Statements in a for should be enclosed in a block • lib/src/database_foundation.dart:225:9 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:237:43 •
          curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/database_foundation.dart:238:7 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/helper_functions.dart:19:5 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/helper_functions.dart:29:5 • curly_braces_in_flow_control_structures
   info • Unnecessary escape in string literal • lib/src/helper_functions.dart:50:45 • unnecessary_string_escapes

23 issues found. (ran in 1.6s)

Part of #37

@github-actions github-actions bot added the dependencies Changing, updating, adding or removing one or more dependencies. label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Visit the preview URL for this PR (updated for commit 097333c):

https://sharezone-test--pr432-add-sharezone-lint-t-rx95cwa0.web.app

(expires Wed, 15 Mar 2023 08:27:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt marked this pull request as ready for review March 7, 2023 22:33
@nilsreichardt nilsreichardt enabled auto-merge (squash) March 8, 2023 08:23
@nilsreichardt nilsreichardt merged commit 323f59d into main Mar 8, 2023
@nilsreichardt nilsreichardt deleted the add-sharezone-lint-to-sharezone-common branch March 8, 2023 08:55
@nilsreichardt nilsreichardt added the refactoring Restructuring and cleaning up existing code without changing its existing behaviour. label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing, updating, adding or removing one or more dependencies. refactoring Restructuring and cleaning up existing code without changing its existing behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants