Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim the "What's new" string when publishing a new version to TestFlight #435

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Trim the "What's new" string when publishing a new version to TestFlight #435

merged 2 commits into from
Mar 8, 2023

Conversation

nilsreichardt
Copy link
Member

Sometimes our updates for TestFlight because of:

PATCH https://api.appstoreconnect.apple.com/v1/betaBuildLocalizations/6206a1b0-01b6-4285-976b-b795f6aaf60c returned 409: An attribute value has invalid text. - Text for whatsNew contains invalid characters/formats.
Failed to publish build/ios/ipa/sharezone.ipa
Error: Process completed with exit code 1.

I assume that this is because of the whitespace at the end (see #422). Therefore, we are trimming now the "What's new" string when pushing to TestFlight.

Closes #422

@github-actions github-actions bot added the ci/cd label Mar 8, 2023
@nilsreichardt nilsreichardt merged commit a8622f5 into main Mar 8, 2023
@nilsreichardt nilsreichardt deleted the trim-last-commit-message branch March 8, 2023 16:35
@nilsreichardt nilsreichardt mentioned this pull request Mar 8, 2023
Merged
nilsreichardt added a commit that referenced this pull request Mar 8, 2023
@nilsreichardt
Fix trim "What's new" string for publishing the alpha version to Test…
f86b8d0 
…Flight (#437)

The alpha workflow is failing:

```
app-store-connect publish: error: argument --whats-new/-n: Provided value "" is not valid
```

I tested #435 locally. However, I tested it wrong which is the reason I
didn't saw this issue...

This time I tested correctly and it should work 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim the changelog for "What's new" when publishing to the App Store / TestFlight
2 participants
@nilsreichardt @Jonas-Sander