Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharezone_lints to app_functions #444

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

nilsreichardt
Copy link
Member

This PR adds sharezone_lints to the app_functions package and fixes the following lint warnings:

Analyzing app_functions...                                              

   info • Don't invoke 'print' in production code • lib/src/app_functions.dart:28:7 • avoid_print
   info • Don't invoke 'print' in production code • lib/src/app_functions.dart:46:5 • avoid_print
   info • Use interpolation to compose strings and values • lib/src/app_functions.dart:46:11 • prefer_interpolation_to_compose_strings
   info • Don't invoke 'print' in production code • lib/src/app_functions.dart:47:5 • avoid_print
   info • Use interpolation to compose strings and values • lib/src/app_functions.dart:47:11 • prefer_interpolation_to_compose_strings
   info • Don't invoke 'print' in production code • lib/src/app_functions.dart:48:5 • avoid_print
   info • Statements in an if should be enclosed in a block • lib/src/app_functions.dart:50:7 • curly_braces_in_flow_control_structures
   info • Statements in an if should be enclosed in a block • lib/src/app_functions.dart:58:7 • curly_braces_in_flow_control_structures
   info • Don't invoke 'print' in production code • lib/src/app_functions.dart:59:5 • avoid_print
   info • Use interpolation to compose strings and values • lib/src/app_functions.dart:59:11 • prefer_interpolation_to_compose_strings
   info • Don't invoke 'print' in production code • lib/src/app_functions.dart:60:5 • avoid_print

Part of #37

@nilsreichardt nilsreichardt added the refactoring Restructuring and cleaning up existing code without changing its existing behaviour. label Mar 9, 2023
@github-actions github-actions bot added the dependencies Changing, updating, adding or removing one or more dependencies. label Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Visit the preview URL for this PR (updated for commit 14d05b5):

https://sharezone-test--pr444-add-sharezone-lints-4v971t8y.web.app

(expires Thu, 16 Mar 2023 17:23:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2023
@nilsreichardt nilsreichardt enabled auto-merge March 9, 2023 17:19
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit d277682 Mar 9, 2023
@nilsreichardt nilsreichardt deleted the add-sharezone-lints-to-app-functions branch March 9, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing, updating, adding or removing one or more dependencies. refactoring Restructuring and cleaning up existing code without changing its existing behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants