Migrate authentication_base package to null safety
#445
Conversation
github-actions
bot
added
dependencies
| DemoUser() | ||
| : super( | ||
| uid: 'testUser', | ||
| firebaseUser: DemoFirebaseUser(), |
There was a problem hiding this comment.
Not sure how we should handle this the DemoUser. Because we are forced to provider a firebaseUser or restructure the user (like making the firebaseUser null). The User of the Firebase Auth package has no constructor so we need to create our own DemoFirebaseUser which brings the problem of implementing methods like delete()
cc: @Jonas-Sander
There was a problem hiding this comment.
Why do we need to implement delete? As long as its only for testing and we don't necessarily need the specific method for a test just make it a no-op.
|
Visit the preview URL for this PR (updated for commit 9b0a53c): https://sharezone-test--pr445-migrate-authenticati-jw4ykupc.web.app (expires Wed, 16 Aug 2023 17:15:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
| @@ -13,27 +13,20 @@ import 'package:sharezone_utils/platform.dart'; | |||
| import 'package:sign_in_with_apple/sign_in_with_apple.dart'; | |||
|
|
|||
| class AppleSignInLogic { | |||
| Future<User> signIn() async { | |||
| Future<User?> signIn() async { | |||
There was a problem hiding this comment.
Shouldn't this throw an Exception or return a user?
…n-base-to-null-safety
github-actions
bot
added
feature: authentification
Closes #207