Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "sz pub get" not running for all packages. #448

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Fix "sz pub get" not running for all packages. #448

merged 5 commits into from
Mar 9, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the dependencies Changing, updating, adding or removing one or more dependencies. label Mar 9, 2023
nilsreichardt
nilsreichardt approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/sz_repo_cli/lib/src/commands/src/pub_get_command.dart Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit eee663f):

https://sharezone-test--pr448-run-sz-get-for-all-p-pqnadoh1.web.app

(expires Thu, 16 Mar 2023 17:42:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander enabled auto-merge (squash) March 9, 2023 14:21
auto-merge was automatically disabled March 9, 2023 14:36

Merge queue setting changed

@Jonas-Sander Jonas-Sander enabled auto-merge March 9, 2023 14:44
@Jonas-Sander Jonas-Sander disabled auto-merge March 9, 2023 14:44
@Jonas-Sander Jonas-Sander enabled auto-merge March 9, 2023 14:44
@Jonas-Sander Jonas-Sander disabled auto-merge March 9, 2023 14:46
@Jonas-Sander Jonas-Sander enabled auto-merge March 9, 2023 14:46
nilsreichardt
nilsreichardt approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(maybe it's smarter for the next time to split this PR into two so that the fix for CI doesn't need to run through the app CI)

@Jonas-Sander
Copy link
Collaborator Author

LGTM

(maybe it's smarter for the next time to split this PR into two so that the fix for CI doesn't need to run through the app CI)

Yeah hadn't thought about that 😅

@nilsreichardt
Copy link
Member

Yeah hadn't thought about that 😅

It's split not to late :D When you cherry pick cc97e32 into a separte branch and revert it in this PR it's still much faster

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit cb40774 Mar 9, 2023
@Jonas-Sander Jonas-Sander deleted the run-sz-get-for-all-packages branch March 9, 2023 19:49
nilsreichardt added a commit that referenced this pull request Mar 10, 2023
@nilsreichardt
Remove "<>" characters when publishing a new version to TestFlight (#465
be1d3c0 
)

The App Store does not allow "<>" characters in the changelog.

The changes transforms the string from:

```
Fix "sz pub get" not running for all packages. (#448) Co-authored-by: Nils Reichardt <[email protected]>
```

Converting it to the following string worked:
```
Fix "sz pub get" not running for all packages. (#448) Co-authored-by: Nils Reichardt [email protected]
```

Tested it locally:

<img width="677" alt="image"
src="https://user-images.githubusercontent.com/24459435/224182253-27090041-d8c6-4d11-ac30-6689215712f2.png">


Closes #464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt