Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dorny/paths-filter instead of native path filters for our CI #456

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Mar 9, 2023

Because merge_groups does not support paths, we try to use the dorny/paths-filter action (workaround from community/community#45899).

We define in the changes check when changeFound should be true. All other checks should wait until path-filter is finished (needs: changes). When other checks are executed, they need to check if changeFound is true. If yes, execute the check, if no, skip.

image

With this workaround for the merge_groups, can we also remove our workaround for required checks that executed based on a path (fallback CI are the recommend workaround from github/docs@4364076)

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Visit the preview URL for this PR (updated for commit 3819764):

https://sharezone-test--pr456-path-filter-action-yoyfejtf.web.app

(expires Thu, 16 Mar 2023 16:31:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt merged commit 2a28524 into main Mar 9, 2023
@nilsreichardt nilsreichardt deleted the path-filter-action branch March 9, 2023 16:41
nilsreichardt added a commit that referenced this pull request Mar 9, 2023
I forgot to remove this in #456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants