Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharezone_lints to sharezone_about_page_addon package #483

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

nilsreichardt
Copy link
Member

This PR adds sharezone_lints to the sharezone_about_page_addon package and fixes the following lint warnings:

Analyzing sharezone_about_page_addon...                                 

   info • Unnecessary 'late' modifier • lib/game/custom/util.dart:11:13 • unnecessary_late
   info • Constructors for public widgets should have a named 'key' parameter • lib/sharezone_about_page_addon.dart:70:7
          • use_key_in_widget_constructors
   info • Invalid use of a private type in a public API • lib/sharezone_about_page_addon.dart:72:3 •
          library_private_types_in_public_api

3 issues found. (ran in 1.0s)

Part of #37

@nilsreichardt nilsreichardt added the refactoring Restructuring and cleaning up existing code without changing its existing behaviour. label Mar 10, 2023
@github-actions github-actions bot added the dependencies Changing, updating, adding or removing one or more dependencies. label Mar 10, 2023
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 22aec79):

https://sharezone-test--pr483-add-sharezone-lints-sygudrun.web.app

(expires Fri, 17 Mar 2023 23:58:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 12, 2023
Merged via the queue into main with commit 06d56f7 Mar 12, 2023
@nilsreichardt nilsreichardt deleted the add-sharezone-lints-to-sharezone-about-page branch March 12, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changing, updating, adding or removing one or more dependencies. refactoring Restructuring and cleaning up existing code without changing its existing behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants