Extend labeler.yml to automatically assign nearly all labels
#493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsreichardt
added a commit
that referenced
this pull request
Mar 12, 2023
According to the Dart Effective Guidelines, we should use snake_case for Dart file. [DO name packages, directories, and source files using lowercase_with_underscores.](https://dart.dev/guides/language/effective-dart/style#do-name-packages-and-file-system-entities-using-lowercase-with-underscores) Used the following command to check if there are still files with camelCase: ```sh find . -name "*.dart" | grep -E '[[:upper:]]' | awk -F/ '{print $NF}' ``` Is helpful for #493 so that labels are assigned correctly.
nilsreichardt
commented
Mar 13, 2023
| - lib/sharezone_widgets/** | ||
| - app/**/widgets/** | ||
| # Assets like images, icons, etc. | ||
| - "**/assets/**" |
| - "**/**theme**" | ||
| - app/fonts/** | ||
| - lib/sharezone_widgets/** | ||
| - app/**/widgets/** |
nilsreichardt
commented
Mar 13, 2023
Comment on lines
+101
to
+103
| - "**/**_web/**" | ||
| - "**/web_**/**" | ||
| - "**/**_web_**/**" |
There was a problem hiding this comment.
Alternative would be to use **/**web**/** instead but now sure if this would lead to too many false positives
Suggested change
| - "**/**_web/**" | |
| - "**/web_**/**" | |
| - "**/**_web_**/**" | |
| - "**/**web**/**" |
Jonas-Sander
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all of our feature labels and a few more labels to our
labeler.ymlwith the goal that 95% of the labeling is done automatically.If we don't automate this process, our PR will have a bad quality of labels.
We try to use general and wide globs for assigning labels. For the "feature: homework" label, do not list all the paths to the homework directories. Instead, just use something like
**/homework/**. This will automatically include the app files, test files, package files and asset files that contain a homework directory. Of course, this can lead to false positives in a few cases. However, we prefer the general glob to the small chance of a false positive because we think the chance of not assigning the label with too specific globs is much higher than having a false positive with a general glob. And when searching for a PR with labels, it is usually better to find a few false positives than not to find a PR about a change in the homework feature that does not have the homework label.We are not going to include "w: " labels because they are too specific and it's too hard to maintain the paths for the files. Searching stuff with the "feature: " label should be enough.