Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for loading groups, timetable and information sheets #498

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Mar 12, 2023

Description

This PR adds an integration test for the following test cases:

  • Loading the groups
  • Loading the timetable
  • Loading the information sheets

Because of #117 and #497 are we blocked to write multiple integration tests. As a workaround can be put integration tests into one test until #117 & #497 are fixed. Not an ideal solution but better than nothing.

Demo

v.mp4

Related Tickets

Closes #499
Closes #500
Closes #501

@github-actions
Copy link

github-actions bot commented Mar 12, 2023

Visit the preview URL for this PR (updated for commit 6de62b9):

https://sharezone-test--pr498-group-page-integrati-hserg63v.web.app

(expires Sun, 19 Mar 2023 19:25:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt changed the title Add integration test for group page Add integration test for group page, timetable page and information sheet page Mar 12, 2023
@nilsreichardt nilsreichardt changed the title Add integration test for group page, timetable page and information sheet page Add integration test for loading groups, timetable and information sheets Mar 12, 2023
@nilsreichardt nilsreichardt marked this pull request as ready for review March 12, 2023 18:53
// * https://github.com/SharezoneApp/sharezone-app/issues/497
// * https://github.com/SharezoneApp/sharezone-app/issues/117

print("Test: User should be able to load groups");
Copy link
Member Author

@nilsreichardt nilsreichardt Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log() prints an empty message when running our integration test. How can we enable the log(). Used the print() as an alternative for now.

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this test is only going through the surface-level pages and looks that the information are there I don't even think its that bad that it is only one test. I think you can just remove the prints or replace them with a comment.

@nilsreichardt
Copy link
Member Author

The idea of the prints are that they should help when the fails to help to identify what part of the test failed

@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 13, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Mar 13, 2023
Merged via the queue into main with commit ce38674 Mar 13, 2023
@nilsreichardt nilsreichardt deleted the group-page-integration-test branch March 13, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants