Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test timeout to 15 minutes. #505

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

Jonas-Sander
Copy link
Collaborator

In #504 running sz test timed out for the sharezone package. From what I can see it doesn't have something to do with the PR in #504 itself, so I increase the timeout from 10 to 15 minutes.

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander enabled auto-merge March 13, 2023 16:25
@github-actions
Copy link

github-actions bot commented Mar 13, 2023

Visit the preview URL for this PR (updated for commit bccea48):

https://sharezone-test--pr505-sz-cli-increate-test-kjlnn5p1.web.app

(expires Mon, 20 Mar 2023 16:28:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt
Copy link
Member

@Jonas-Sander I would recommend to first merge #504 and then this PR because otherwise you need to wait ~45 minutes until you have #504 in the main branch because this PR also executes the integration tests

@Jonas-Sander
Copy link
Collaborator Author

@Jonas-Sander I would recommend to first merge #504 and then this PR because otherwise you need to wait ~45 minutes until you have #504 in the main branch because this PR also executes the integration tests

So should I force-merge the other PR even if the test job fails again?

@nilsreichardt
Copy link
Member

So should I force-merge the other PR even if the test job fails again?

No, but the test job will finish in the next minutes because the timeout is flaky. Re-trigger the CI is enough

@Jonas-Sander Jonas-Sander disabled auto-merge March 13, 2023 16:35
@Jonas-Sander Jonas-Sander enabled auto-merge March 13, 2023 16:44
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Mar 13, 2023
Merged via the queue into main with commit f74f283 Mar 13, 2023
@Jonas-Sander Jonas-Sander deleted the sz-cli-increate-test-timeout branch March 13, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants