Remove deprecated Android SplashScreenDrawable.
#539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still used an deprecated way to declare a splash screen, which caused the following warning to be printed on Android start-up: `W/FlutterActivityAndFragmentDelegate( 6179): A splash screen was provided to Flutter, but this is deprecated. See flutter.dev/go/android-splash-migration for migration steps.` Since we also already use the recommand way to declare a splash screen additionally, we just had to remove the old way. There are no behavior / splash screen changes, everything works as it used to.
|
To view this pull requests documentation preview, visit the following URL: docs.page/sharezoneapp/sharezone-app~539 Documentation is deployed and generated using docs.page. |
|
Visit the preview URL for this PR (updated for commit d347bac): https://sharezone-test--pr539-remove-deprecated-an-3z8847fl.web.app (expires Thu, 17 Aug 2023 00:26:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
nilsreichardt
added
the
build-app-preview
|
⬇️ Generated builds by Codemagic for commit d347bac ⬇️ Note: Only Sharezone team members are able to install the iOS app.
|
…roid-splash-screen
nilsreichardt
removed
the
build-app-preview
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still used an deprecated way to declare a splash screen, which caused the following warning to be printed on Android start-up:
W/FlutterActivityAndFragmentDelegate( 6179): A splash screen was provided to Flutter, but this is deprecated. See flutter.dev/go/android-splash-migration for migration steps.Since we also already use the recommended way to declare a splash screen additionally, we just had to remove the old way. There are no behavior / splash screen changes, everything works as it used to.