Fix comment spacing fixes for Windows (CRLF). #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nilsreichardt Man I thought I went crazy 😂 When I copied out the comments which were flagged as "badly spaced" on Windows into the test file it must have had automatically changed the line endings. That means after I copied the comments into the tests they were not badly spaced anymore according to my code 🤯 |
nilsreichardt
added a commit
that referenced
this pull request
Sep 24, 2023
`/mobile-store` should open on Android & iOS the store of the OS. This link should replace the https://onelink.to in the app: https://github.com/SharezoneApp/sharezone-app/blob/2f5b5ad5e2d12bef52db30a86a5240feebe008ef/app/lib/pages/settings/changelog_page.dart#L200 Using our own link has the advantage that if https://onelink.to removes our link that we can replace the redirect without an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has CRLF line endings for files ("\r\n") while Linux and macOS use LF ("\n").
The comment spacing fixes could handle LF but not CRLF. This is fixed with this PR.