Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace package:tuneup with the Dart analyzer. #542

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Replace package:tuneup with the Dart analyzer. #542

merged 1 commit into from
Apr 1, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

Replace the deprecated package:tuneup with the Dart analyzer to check for analyzer errors/warnings/infos when running sz analyze. See: #480

Closes #480.

@Jonas-Sander
Replace package:tuneup with the Dart analyzer.
22b1f2f 
Replace the deprecated `package:tuneup` with the Dart analyzer to check for analyzer errors/warnings/infos when running `sz analyze`.
See: #480

Closes #480.
@docs-page
Copy link

docs-page bot commented Mar 31, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~542

Documentation is deployed and generated using docs.page.

@Jonas-Sander Jonas-Sander added the code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. label Mar 31, 2023
nilsreichardt
nilsreichardt approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Apr 1, 2023
Merged via the queue into main with commit 560f512 Apr 1, 2023
@Jonas-Sander Jonas-Sander deleted the replace-tuneup-with-dart-analyze branch April 1, 2023 13:55
@github-actions github-actions bot removed the code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace package:tuneup used in the Sharezone CLI.
2 participants
@Jonas-Sander @nilsreichardt