Fix how Process output in sz cli is captured to (hopefully) fix timout issue. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nilsreichardt Again a fuc___ weird issue 😂😅 |
|
I think the solution is to go MacBook-only 😎 |
nilsreichardt
added a commit
that referenced
this pull request
Sep 24, 2023
The `build_context` is the reason why our builds are failing: https://github.com/SharezoneApp/website/actions/runs/5942916196/job/16116942873. Because there is no new version of `build_context` I just removed the package from our codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI Pipeline for #51 had timeouts.
While investigating the issue I found out that it seems like
dart pub getdoesn't close it'sstderrStream when having an error thus causing waiting for inifinity if one depends on a closed stream (e.g. to capture the error output fully).Additionally
await process.exitCodedoesn't seem to finish when I'm not listening toprocess.stdoutorprocess.stderr.I think this is also only for
dart pub getbut I'm not sure really :/