Fix freeze when signing out on web #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/sharezoneapp/sharezone-app~573 Documentation is deployed and generated using docs.page. |
|
Visit the preview URL for this PR (updated for commit e9f1e76): https://sharezone-test--pr573-fix-freeze-when-sign-m37zyxf0.web.app (expires Thu, 13 Apr 2023 11:34:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
nilsreichardt
added
platform: web
feature: navigation
|
If it never should be null then we should actually investigate why this is happening or not? |
Jonas-Sander
approved these changes
Apr 6, 2023
|
I opened #608 |
nilsreichardt
removed this pull request from the merge queue due to the queue being cleared
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
## Summary This PR fixes: * #608 * #654 * #497 (real fix) It's required to this all in one pull request because otherwise it would introduce a new bug. ## What was the issue? I started to debug on this problem because of #654. I found out it was because `TypeOfUser.student` was used as a backup when it's null (see #573). However, just reverting it to `TypeOfUser.unknown` was not option because this would introduce #497 again. Therefore, I wondered, why `typeOfUser` can be null. The reason for this was the last time online reporter. Because `.set()` has been used for Firestore, Firestore instantly was setting it null (I think `null` is used for `Firestore.currentTimestamp()` when the client is offline or the server hasn't responded yet). Using `.update()` fixed the issue that the user document only contained `lastOnline`. But using `update()` in the last online reporter always caused #497. Even using `TypeOfUser.student` or `TypeOfUser.unknown` couldn't be as a workaround. After hours of debugging I found that when signing our the following line was causing the issue: https://github.com/SharezoneApp/sharezone-app/blob/47e4ccb0993f01b5c9b8c83f31f7ec4c4f833c77/app/lib/util/api/homework_api.dart#L107 The issue is that we listened to `_homeworkSubjectStream` and when an error occurred, we the `.addError` method of `_homeworkSubjectStream ` used. This ended up into an infinity loop which resulted in the freeze (#497), This was by far one of my hardest bugs... I needed ~5,5h to find the solution and it was extremely hard to debug. Fixes #608 Fixes #654 Fixes #497 --------- Co-authored-by: Jonas Sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through Git binary search, I found out that the issue #497 was caused by #469. I don't why the web app crashes when the
AppUserisTypeOfUser.unknown. We are never using theTypeOfUser.unknownstate. However, usingTypeOfUser.studentworks and I think should be okay as a fallback value, becausetypeOfUsershould never be null.Screen.Recording.2023-04-06.at.00.48.29.mov
Closes #497