Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new line when adding the event description while adding a new event #586

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

nilsreichardt
Copy link
Member

Description

Before the PR you could only add a new line by adding the event and then editing the event. Now it's possible to add a new line while adding a new event.

Demo

Normal use case:

Screen.Recording.2023-04-06.at.14.17.54.mov

Edge case:

Screen.Recording.2023-04-06.at.14.25.07.mov

Related Tickets

Fixes #585

@docs-page
Copy link

docs-page bot commented Apr 6, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~586

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added the feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). label Apr 6, 2023
@nilsreichardt nilsreichardt changed the title Long text field for event description Allow new line when adding the event description while adding a new event Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Visit the preview URL for this PR (updated for commit 553ae48):

https://sharezone-test--pr586-long-text-field-even-107cedkx.web.app

(expires Thu, 13 Apr 2023 12:30:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt enabled auto-merge April 6, 2023 14:03
@nilsreichardt nilsreichardt added this pull request to the merge queue Apr 6, 2023
Merged via the queue into main with commit 51933a2 Apr 6, 2023
@nilsreichardt nilsreichardt deleted the long-text-field-event-description branch April 6, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to press new line on the keyboard when entering the description of an event
2 participants