Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sz CLI: Move logic out of package.dart. #618

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

Instead of letting package.dart grow and grow, I moved all of the logic out to the xxx_command.dart classes.
Additionally I removed the DartPackage and FlutterPackage subclasses as they are unnecessary with the logic moved elsewhere.

@docs-page
Copy link

docs-page bot commented Apr 7, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~618

Documentation is deployed and generated using docs.page.

@Jonas-Sander
Copy link
Collaborator Author

This PR also created a SST method for formatting Dart code like you mentioned in the last PR @nilsreichardt

@Jonas-Sander Jonas-Sander marked this pull request as ready for review April 7, 2023 12:37
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander enabled auto-merge April 7, 2023 12:50
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Apr 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2023
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Apr 7, 2023
Merged via the queue into main with commit c0e551a Apr 7, 2023
@Jonas-Sander Jonas-Sander deleted the sz-cli-move-logic-out-of-package branch April 7, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants