Add VisualDensitySetting class.
#624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/sharezoneapp/sharezone-app~624 Documentation is deployed and generated using docs.page. |
Jonas-Sander
commented
Apr 19, 2023
Comment on lines
133
to
138
| data: { | ||
| 'visual_density': { | ||
| 'horizontal': value.horizontal, | ||
| 'vertical': value.vertical | ||
| } | ||
| // bool is not allowed in firebase_analytics so we use `toString`. | ||
| 'isAdaptivePlatformDensity': value.isAdaptivePlatformDensity.toString(), | ||
| 'horizontal': value.visualDensity.horizontal, | ||
| 'vertical': value.visualDensity.vertical | ||
| }, |
There was a problem hiding this comment.
The old code would have always thrown an error here since the map inside map ('data:': { 'visual_density': {...}}) is not allowed by firebase_analytics.
|
Visit the preview URL for this PR (updated for commit a94fa0f): https://sharezone-test--pr624-theme-settings-visua-n7iwvicu.web.app (expires Wed, 26 Apr 2023 19:30:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is a prerequisite for #79.
With this class we can track if the user has manually chosen a specific
VisualDensityor if they use the defaultVisualDensity.adaptivePlatformDensity(one can't tell by looking just at theVisualDensityclass).