Replace open_file package with open_file_plus.

[Jonas-Sander]

Fixes Android permission errors that come up on >= Android 11: Permission denied: android.Manifest.permission.MANAGE_EXTERNAL_STORAGE.

Note: I only tested this works on Android 11, not earlier versions.

[docs-page]

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~636

Documentation is deployed and generated using docs.page.

[github-actions]

Visit the preview URL for this PR (updated for commit 8333b03):

https://sharezone-test--pr636-replace-open-file-wi-tcze195v.web.app

_{(expires Wed, 10 May 2023 16:46:44 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b}

[Jonas-Sander]

Right now when trying to open files on Android with an extension in uppercase (e.g. Warning.PNG) the following error will come up: open file result: the /data/user/0/de.codingbrain.sharezone.dev/cache/libCachedImageData/Warning.png file does not exists.

If _getFilePathWithLowerCaseExtension is removed it works, but idk if this would break clients below Android 11. For now I'll not change the behavior in this PR.

sharezone-app/app/lib/filesharing/widgets/download_unknown_file_type_dialog_content.dart

Lines 88 to 94 in 007a722

	if (PlatformCheck.isIOS) {
	OpenFile.open(future.data.getPath());
	} else {
	OpenFile.open(
	_getFilePathWithLowerCaseExtension(future.data.getPath()))
	.then((result) => log('open file result: ${result.message}'));
	}

[Jonas-Sander]

Hm idk why the file diffs look so weird, did the line endings change because I'm on Windows maybe? But I made several PRs from Windows and this hasn't happend before 🤔

[Jonas-Sander]

Hm idk why the file diffs look so weird, did the line endings change because I'm on Windows maybe? But I made several PRs from Windows and this hasn't happend before 🤔

Hm, fixed it now by running git config --global core.autocrlf true and git add --renormalize [file_path] for the affected files.

[Jonas-Sander]

Right now when trying to open files on Android with an extension in uppercase (e.g. Warning.PNG) the following error will come up: open file result: the /data/user/0/de.codingbrain.sharezone.dev/cache/libCachedImageData/Warning.png file does not exists.

If _getFilePathWithLowerCaseExtension is removed it works, but idk if this would break clients below Android 11. For now I'll not change the behavior in this PR.

sharezone-app/app/lib/filesharing/widgets/download_unknown_file_type_dialog_content.dart

Lines 88 to 94 in 007a722

	if (PlatformCheck.isIOS) {
	OpenFile.open(future.data.getPath());
	} else {
	OpenFile.open(
	_getFilePathWithLowerCaseExtension(future.data.getPath()))
	.then((result) => log('open file result: ${result.message}'));
	}

Idk if I'll get to it atm, could I pass this task to you @nilsreichardt ? (In another PR though)

[nilsreichardt]

_getFilePathWithLowerCaseExtension

Yes, I'm opened #637

[nilsreichardt]

LGTM

I have successfully tested it with Android 13 and macOS. On Android 5 (I used an emulator) it opened the app to view the file on the phone. However, this app couldn't the image. Not sure if this an issue caused by the package or just an issue with the Android emulator. I would just merge it for now 👍