Fix launching Sharezone when using Dynamic Link on Android #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/sharezoneapp/sharezone-app~665 Documentation is deployed and generated using docs.page. |
Jonas-Sander
approved these changes
May 9, 2023
|
Visit the preview URL for this PR (updated for commit 7fd7a3a): https://sharezone-test--pr665-fix-opening-sharezon-6caj71p6.web.app (expires Tue, 16 May 2023 13:34:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nilsreichardt
added a commit
that referenced
this pull request
Aug 26, 2023
In #665 I added `sharezone.net` as Android Intent because it seemed to be needed to be able to open Firebase Dynamic Links. However, this breaks nearly all `sharezone.net/...` links because instantly the app opens instead the link, like `https://sharezone.net/discord`. I tested the change and the Firebase Dynamic Links still worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this issue was that
intent-filterwas missing.For some reason, I also needed to add
sharezone.netto get the Dynamic Links working, which is a bit weird. I thinksharezone.netis coming fromhttps://github.com/SharezoneApp/backend-mono/blob/1d402c3a1817c24e04d4f781405fdcc3af350209/infrastructure/google_cloud_platform/firebase/cloud_functions/functions/src/dynamic_links/dynamic_links.ts#L14
Fixes #661