Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CD workflow to deploy new iOS stable versions #699

Merged
merged 5 commits into from
Aug 6, 2023

Conversation

nilsreichardt
Copy link
Member

This pull request introduces a new GitHub Actions workflow for deploying new stable versions of our application.

The workflow, named 'stable', ensures that our iOS builds are built sequentially to maintain unique build numbers, a requirement of iOS builds. The concurrency group, 'app-release', enforces that only one version is built per branch at a time.

A manual trigger has been implemented via the workflow_dispatch event. This requires the input of a changelog for the iOS release. This changelog is subsequently used as the release notes in the App Store release.

@docs-page
Copy link

docs-page bot commented Jul 30, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~699

Documentation is deployed and generated using docs.page.

description: |
The changelog for the iOS release. This will be used as the release
notes in the App Store release.
required: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we add an option that you can select which platforms should get a new stable release? Imagine that we fix a web only bug and we want only deploy web.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds like a nice idea. Good thinking! :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the description to:

iOS changelog: Used for the App Store release notes. If the changelog is not provided, the deployment for iOS will be skipped.

Assuming that if there is no changelog, nothing has changed for iOS and no new deployment is needed.

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2023
Since we also have a workflow to deploy stable versions (#699) we need
to use the same name for the concurrency group because in these
workflows we access the latest build number from App Store Connect.
@nilsreichardt
Copy link
Member Author

Status: I need also apply the fixes from #709, #708 and #707

@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 6, 2023
Merged via the queue into main with commit c887ce0 Aug 6, 2023
@nilsreichardt nilsreichardt deleted the add-deploy-ios-to-stable-workflow branch August 6, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants