-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CD workflow to deploy new iOS stable versions #699
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/sharezoneapp/sharezone-app~699 Documentation is deployed and generated using docs.page. |
.github/workflows/stable.yml
Outdated
description: | | ||
The changelog for the iOS release. This will be used as the release | ||
notes in the App Store release. | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we add an option that you can select which platforms should get a new stable release? Imagine that we fix a web only bug and we want only deploy web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that sounds like a nice idea. Good thinking! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed the description to:
iOS changelog: Used for the App Store release notes. If the changelog is not provided, the deployment for iOS will be skipped.
Assuming that if there is no changelog, nothing has changed for iOS and no new deployment is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM 👍
Since we also have a workflow to deploy stable versions (#699) we need to use the same name for the concurrency group because in these workflows we access the latest build number from App Store Connect.
This pull request introduces a new GitHub Actions workflow for deploying new stable versions of our application.
The workflow, named 'stable', ensures that our iOS builds are built sequentially to maintain unique build numbers, a requirement of iOS builds. The concurrency group, 'app-release', enforces that only one version is built per branch at a time.
A manual trigger has been implemented via the workflow_dispatch event. This requires the input of a changelog for the iOS release. This changelog is subsequently used as the release notes in the App Store release.