Skip image compressing for macOS #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/sharezoneapp/sharezone-app~714 Documentation is deployed and generated using docs.page. |
github-actions
bot
added
feature: file-sharing
|
Visit the preview URL for this PR (updated for commit 059c819): https://sharezone-test--pr714-skip-compressing-fil-l7d9a3z0.web.app (expires Sun, 13 Aug 2023 18:41:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Aug 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a limitation with the
flutter_image_compresslibrary on macOS. Due to a known issue, the image compressor does not work on macOS, leading to potential runtime errors or unexpected behavior.Changes:
Reason for Change:
The
flutter_image_compresslibrary has a known issue on macOS which causes the compression functionality to fail. Refer to the following issue for more details: fluttercandies/flutter_image_compress#255.By skipping the image compression step on macOS, we ensure that our users do not encounter unexpected errors or issues while using the app on this platform. The changes are a temporary measure until a fix or alternative solution is found for the underlying library issue.
Testing:
Related Tickets
Fixes #713