Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate files_web to null safety. #730

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Migrate files_web to null safety. #730

merged 1 commit into from
Aug 9, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Aug 9, 2023 •
edited by nilsreichardt
Loading

Closes #196

@docs-page
Copy link

docs-page bot commented Aug 9, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~730

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added platform: web feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. dependencies Changing, updating, adding or removing one or more dependencies. labels Aug 9, 2023
nilsreichardt
nilsreichardt approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilsreichardt nilsreichardt enabled auto-merge August 9, 2023 17:41
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Visit the preview URL for this PR (updated for commit 1c1caf1):

https://sharezone-test--pr730-migrate-files-web-pa-j3cjo3p8.web.app

(expires Wed, 16 Aug 2023 17:45:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 9, 2023
@Jonas-Sander Jonas-Sander removed this pull request from the merge queue due to a manual request Aug 9, 2023
@Jonas-Sander Jonas-Sander merged commit e297836 into main Aug 9, 2023
@Jonas-Sander Jonas-Sander deleted the migrate-files-web-package-to-null-safety branch August 9, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. platform: web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate the files_web package to null safety
2 participants
@Jonas-Sander @nilsreichardt