Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sharezone_lints to abgabe_http_api #734

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Add sharezone_lints to abgabe_http_api #734

merged 2 commits into from
Aug 10, 2023

Conversation

nilsreichardt
Copy link
Member

Part of #37

@docs-page
Copy link

docs-page bot commented Aug 9, 2023

To view this pull requests documentation preview, visit the following URL:

docs.page/sharezoneapp/sharezone-app~734

Documentation is deployed and generated using docs.page.

@github-actions github-actions bot added code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. dependencies Changing, updating, adding or removing one or more dependencies. labels Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit aa84656):

https://sharezone-test--pr734-add-sharezone-lints-w7ktyoa0.web.app

(expires Thu, 17 Aug 2023 00:25:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt disabled auto-merge August 10, 2023 00:21
Jonas-Sander
Jonas-Sander approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an auto-generated library, I don't really think that this makes sense. But since you already changed it, its okay to merge.

@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit c661095 Aug 10, 2023
@nilsreichardt nilsreichardt deleted the add-sharezone-lints-to-abgabe-http-api branch August 10, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander