-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing sz deploy macos
for Automating macOS App Deployment
#745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I think some code could be shared between the iOS and macOS deploy command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, although I think some changes should be made. I'm gonna elaborate tomorrow on Discord :)
Implemented :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! :)
Description
This pull request introduces a significant enhancement to our deployment pipeline, specifically for the macOS app. It automates various stages of the deployment process, including the retrieval of the next build number, app building, and publication to the App Store or TestFlight.
Key changes include:
Deployment Stages and Flavors: The code defines different stages (
stable
,alpha
) and flavors (prod
) for the macOS app deployment. This allows for flexibility in managing various versions of the app.Command Line Options: Several command-line options have been added to provide necessary parameters for the deployment process. These include API keys, issuer ID, private key, release notes, and the build flavor.
Build Number Automation: The function
_getNextBuildNumber
is implemented to fetch the latest build number from App Store Connect and increment it for the next build.App Building and Publishing: Functions for building the app (
_buildApp
) and publishing it (_publish
) have been implemented. They use the Codemagic CLI tools and require the build number as an argument.Environment Variables: Sensitive information, such as API keys, are fetched from environment variables, keeping them secure and out of the codebase.
Refactoring of common methods: Common methods that are used to interact with App Store Connect are now globally available and can be reused in the iOS command.
This new implementation greatly simplifies the macOS deployment process, making it more streamlined and less prone to manual errors.
Testing
Usage
sz deploy macos --help