Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file_chooser package #83

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Jan 26, 2022

This removes a package with Code that was developed and licenced by Google.
We can use it as it is licenced under MIT but as we will open source with #82 we don't want to go into any risks (because of mixing differently licenced/copyrighted code in the same repo).

Merge this before #82
Fixes #84

@nilsreichardt
Copy link
Member

Fixes this #84?

@Jonas-Sander Jonas-Sander changed the title [WIP] Replace file_chooser package Replace file_chooser package Jan 26, 2022
@Jonas-Sander
Copy link
Collaborator Author

Fixes this #84?

Yes, we accessed file.path before which throws after an update of the dependency I guess.
So now we just pass null to our own LocalFile class instead and the upload works again.

@Jonas-Sander
Copy link
Collaborator Author

Couldn't test it on macOS even when merging #64 btw - would still merge it.

@Jonas-Sander Jonas-Sander merged commit de11659 into main Jan 26, 2022
@Jonas-Sander Jonas-Sander deleted the replace-file-chooser-package branch January 26, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading files is not working anymore (only web app)
2 participants