Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Flutter v3.13.1 #844

Merged
merged 20 commits into from
Aug 29, 2023
Merged

Upgrade to Flutter v3.13.1 #844

merged 20 commits into from
Aug 29, 2023

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Aug 28, 2023 •
edited
Loading

Summary

  • Set Flutter version to v3.13.1
  • Set minimum Dart SDK to 3.1 to allow us to use the latest Dart features
  • Upgraded a few dependencies
  • Migrated all breaking changes
  • Removed the Dino game because it had too many breaking changes (RIP Dino game 🪦 maybe one day it comes back)

Our "new" Easter egg. I just picked something easy - just changing the text scaling size. No time and energy at the moment to make something good 😬

Screen.Recording.2023-08-28.at.21.55.35.mov

@github-actions github-actions bot added code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. platform: web feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: notifications Push-Notifications and In-App-Notifications. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: holidays feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. feature: navigation Navigation inside the app (e.g. switching to a different screen). testing feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. sharezone cli dependencies Changing, updating, adding or removing one or more dependencies. feature: analytics Includes everything that is related to analytics and usage tracking w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.). labels Aug 28, 2023
@nilsreichardt nilsreichardt mentioned this pull request Aug 28, 2023
Merged
@nilsreichardt nilsreichardt added the build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. label Aug 28, 2023
@github-actions github-actions bot added the ci/cd label Aug 28, 2023
@Sharezone-Admin
Copy link
Member

Sharezone-Admin commented Aug 28, 2023 •
edited
Loading

⬇️ Generated builds by Codemagic for commit da556f0 ⬇️

Note: Only Sharezone team members are able to install the iOS app.

iOS Android
image
Download link		 image
Download link

@nilsreichardt nilsreichardt removed the build-app-preview A label that can be assigned to a PR to trigger a build of the app preview. label Aug 28, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 29, 2023
@nilsreichardt nilsreichardt mentioned this pull request Aug 29, 2023
Closed
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2023
@nilsreichardt
Add --update-goldens flag to sz test (#845)
abdc6f5 
Sometimes you want to update all golden files, like when a Flutter
version changed the render behavior (see #844) or if the theme changes.
For that, you just pass `--update-goldens` to `sz test` to update all
golden tests.

Example:
```sh
sz test --update-goldens
```
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 29, 2023
@github-actions github-actions bot removed the ci/cd label Aug 29, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit fc4454d Aug 29, 2023
@nilsreichardt nilsreichardt deleted the upgrade-flutter-3-13-1 branch August 29, 2023 21:25
@nilsreichardt nilsreichardt mentioned this pull request Sep 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 21, 2023
@nilsreichardt
Update minium Dart SDK and add sharezone_lints to qr_code_scanner…
a754a83 
… package (#1051)

I forgot to set the minimum Dart SDK of this package in #844.
@nilsreichardt nilsreichardt mentioned this pull request Sep 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
code quality Code quality itself (readable) but e.g. also how we might enforce better quality automatically. dependencies Changing, updating, adding or removing one or more dependencies. documentation feature: analytics Includes everything that is related to analytics and usage tracking feature: authentification Logging in/out (anonymous, sign-in with X, etc.) and registration. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: holidays feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: information sheet Information sheets are posted to courses as a way to announce information. feature: navigation Navigation inside the app (e.g. switching to a different screen). feature: notifications Push-Notifications and In-App-Notifications. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. platform: android platform: ios platform: macos platform: web sharezone cli testing ui / ux w: dashboard-page Page that shows a summary of all important things (homeworks, events, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsreichardt @Sharezone-Admin @Jonas-Sander