Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package:optional. #876

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Remove package:optional. #876

merged 3 commits into from
Sep 7, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

We're now using nullable types instead of using package:optional.

Fixes #749

@github-actions github-actions bot added feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) testing feature: onboarding The steps (setting username, courses, etc.) after creating a new account. user: teacher sharezone cli dependencies Changing, updating, adding or removing one or more dependencies. labels Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit a155c62):

https://sharezone-test--pr876-remove-package-optio-g4ch7fdf.web.app

(expires Sun, 10 Sep 2023 11:56:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

nilsreichardt
nilsreichardt approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Sep 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 7, 2023
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Sep 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 7, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit 7132bd0 Sep 7, 2023
@nilsreichardt nilsreichardt deleted the remove-package-optional branch September 7, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. sharezone cli testing user: teacher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usage of package:optional from code.
2 participants
@Jonas-Sander @nilsreichardt