Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of sz deploy android command #880

Merged
merged 16 commits into from
Sep 4, 2023
Merged

Conversation

nilsreichardt
Copy link
Member

Description:

This pull request introduces the sz deploy android command into our CLI. The new command is designed to automate and simplify the process of building and deploying the Sharezone Android app to Google Play.

Key Features:

  1. Stage Selection: Users can specify whether they want to deploy the app to the 'stable' or 'beta' stage in Google Play.
  2. Flavor Support: Currently, only the 'prod' flavor is supported for deployment, but the architecture allows for easy addition of more flavors in the future.
  3. Build Number Automation: The command fetches the latest build number from Google Play and automatically increments it for the new release.
  4. Changelog Integration: Users can provide release notes, which are automatically integrated with Fastlane for Play Store submission. If no changelog is provided, the step is gracefully skipped.
  5. Google Play Credentials Validation: Before deployment, the command checks if Fastlane can establish a connection to Google Play, ensuring no unexpected authentication issues during deployment.
  6. Track Mapping: Depending on the specified stage (beta or stable), the command determines the correct Google Play track for the deployment.

Changes Introduced:

  • Defined the possible stages and flavors for the Android app deployment.
  • Introduced argument parsers for the stage, flavor, and whats-new options.
  • Added methods to validate Google Play credentials, fetch the latest build number, build the app, and publish it to Google Play.
  • Integrated Fastlane and Codemagic CLI tools for building and deployment.

Usage:

sz deploy android --stage [stable|beta] --flavor prod --whats-new "Your release notes here"

Note:
Ensure that Fastlane and Codemagic CLI tools are correctly installed and set up before using this command. Also, Google Play credentials should be properly configured in Fastlane.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Visit the preview URL for this PR (updated for commit 0e1dc15):

https://sharezone-test--pr880-add-fastlane-android-1prgz5wx.web.app

(expires Thu, 07 Sep 2023 16:25:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt marked this pull request as ready for review September 4, 2023 16:20
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will the Gemfile.lock need a regular update (similar to running pub get for our packages)? If so, how would one update it?

@nilsreichardt
Copy link
Member Author

LGTM. Will the Gemfile.lock need a regular update (similar to running pub get for our packages)? If so, how would one update it?

I don't think that the Gemfile.lock needs a regular update.

However, if you still need to update them, you use the following command:

[sudo] bundle update

For more information: https://chat.openai.com/share/69c2afd4-0e1d-4747-912e-8cbb08d321b1

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit 4eeddeb Sep 4, 2023
@nilsreichardt nilsreichardt deleted the add-fastlane-android branch September 4, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants