Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors when Firebase remote fetch didn't work. #907

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

nilsreichardt
Copy link
Member

If you have a very slow internet connection, the Firebase Remote Config fetch method could fail with an unknown error. This could cause our integration test to fail and result in a Crashlytics report. Therefore, we should catch the failed fetch.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Visit the preview URL for this PR (updated for commit 0aa1486):

https://sharezone-test--pr907-catch-error-in-remot-nqmsf769.web.app

(expires Sun, 10 Sep 2023 12:59:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit e4854bb Sep 7, 2023
@nilsreichardt nilsreichardt deleted the catch-error-in-remote-config branch September 7, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants