Add signing steps to the sz deploy ios command
#911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-Sander
reviewed
Sep 8, 2023
Co-authored-by: Jonas Sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run the signing steps in the GitHub Actions file. However, we can't do this for the macOS release because signing is part of the deploy process. As prework, I added the signing steps to the iOS command because the signing for iOS is easier than for macOS. When this works, can we make a new PR for the
sz deploy macoscommand.Manually tested it with: https://github.com/SharezoneApp/sharezone-app/actions/runs/6119211836/job/16608705828