Add new welcome page #917
Merged
Add new welcome page #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ui / ux
testing
feature: onboarding
|
Visit the preview URL for this PR (updated for commit 069e57b): https://sharezone-test--pr917-new-welcome-page-4fsnsafp.web.app (expires Mon, 11 Sep 2023 17:50:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
@nilsreichardt This looks kinda off though
There was a problem hiding this comment.
Yes, this is true. However, I think it's okay for now because making it pretty for phone landscape adds some complexity and as long it's looks okay and doesn't throw exceptions I would use it for now
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new welcome page to our page. However, for now, the screen is in light mode only. I will add a welcome page in dark mode later (see #916).
Demo
v.mp4
Related tickets
Closes #851