Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more group analytics #930

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Add more group analytics #930

merged 3 commits into from
Sep 9, 2023

Conversation

nilsreichardt
Copy link
Member

No description provided.

@github-actions github-actions bot added feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups Groups umbrella term for courses and classes. feature: onboarding The steps (setting username, courses, etc.) after creating a new account. feature: analytics Includes everything that is related to analytics and usage tracking labels Sep 8, 2023
nilsreichardt
nilsreichardt commented Sep 8, 2023
View reviewed changes
app/lib/groups/analytics/group_analytics.dart
GroupEvent(String name) : super('group_$name');
}

class GroupSettingsEvent extends GroupEvent {
Copy link
Member Author

@nilsreichardt nilsreichardt Sep 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the GroupSettingsEvent class because with a `_settings' prefix in the analytics name we easily hit the 32 character limit for an analytics name.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 36ca45d):

https://sharezone-test--pr930-add-more-group-analy-dqnz3icp.web.app

(expires Tue, 12 Sep 2023 05:57:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt mentioned this pull request Sep 8, 2023
Merged
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 9, 2023
Merged via the queue into main with commit e37a3ea Sep 9, 2023
@nilsreichardt nilsreichardt deleted the add-more-group-analytics branch September 9, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
feature: analytics Includes everything that is related to analytics and usage tracking feature: groups:classes Specific to only classes (instead of e.g. courses) feature: groups:courses Specific to only courses (instead of e.g. classes) feature: groups Groups umbrella term for courses and classes. feature: onboarding The steps (setting username, courses, etc.) after creating a new account.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander