Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minifyEnabled flag for Android for a readable Crashlytics stack trace #946

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Sep 13, 2023

We had the problem that our stack trace was not readable (see #835). This is a huge problem for us because we want to detect errors in our beta and alpha versions and fix them. Without the stack trace it's super hard to fix them.

I'm pretty sure that the minifyEnabled flag obfuscates the stack trace. I would value the stack trace much higher than a bit smaller APK file. But I also made the test:

  1. Run sz build android --output-type apk (with minifyEnabled): 54.0 MB
  2. Run fvm flutter clean && sz build android --output-type apk (without minifyEnabled): 54.0 MB

Fixes #835

@nilsreichardt nilsreichardt changed the title Remove minifyEnabled flag for Android for a readable Crashlytics st… Remove minifyEnabled flag for Android for a readable Crashlytics stack trace Sep 13, 2023
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Visit the preview URL for this PR (updated for commit 7b143e0):

https://sharezone-test--pr946-remove-minify-flag-mw0ttfci.web.app

(expires Sat, 16 Sep 2023 08:56:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@nilsreichardt nilsreichardt marked this pull request as ready for review September 13, 2023 08:52
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 48157c2 Sep 13, 2023
@nilsreichardt nilsreichardt deleted the remove-minify-flag branch September 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashlytics stacktrace is obfuscated
2 participants