Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only Sharezone Plus users to change the homework reminder time #991

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

nilsreichardt
Copy link
Member

Demo

image image

Related Tickets

Closes #886

@github-actions github-actions bot added feature: notifications Push-Notifications and In-App-Notifications. testing feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Sep 17, 2023
final buttonShape = RoundedRectangleBorder(
borderRadius: BorderRadius.circular(12.5),
);
return AlertDialog(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll later make a more abstract widget in the sharezone_widgets package to be able to reuse this dialog for other features. Later on, we can also implement in this dialog the logic for displaying a short demo video (mobile video for mobile devices and landscape video for landscape devices).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

github-actions bot commented Sep 17, 2023

Visit the preview URL for this PR (updated for commit 3fa59e4):

https://sharezone-test--pr991-notifications-plus-69b3gzuf.web.app

(expires Fri, 22 Sep 2023 10:14:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander changed the title Allow only Sharezone Plus users to chagne the homework reminder time Allow only Sharezone Plus users to change the homework reminder time Sep 17, 2023
app/lib/pages/settings/notification.dart Outdated Show resolved Hide resolved
app/test/pages/settings/notification_page_test.dart Outdated Show resolved Hide resolved
app/test/pages/settings/notification_page_test.dart Outdated Show resolved Hide resolved
app/test/pages/settings/notification_page_test.dart Outdated Show resolved Hide resolved
@Jonas-Sander
Copy link
Collaborator

Looks nice 👍

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 1ebee74 Sep 19, 2023
@nilsreichardt nilsreichardt deleted the notifications-plus branch September 19, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: homework feature: notifications Push-Notifications and In-App-Notifications. feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription testing ui / ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict changing the homework reminder time for non Sharezone Plus users
2 participants